kinow commented on code in PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#discussion_r1564303009
##########
src/test/resources/data/images/jpg/8/20220514_102409.jpg:
##########
Review Comment:
~450kb, tried reducing the image with GIMP, but that caused the image to not
fail the test anymore :man_shrugging: , but I think 450kb for a new test file
is OK.
##########
src/changes/changes.xml:
##########
@@ -48,10 +48,13 @@ The <action> type attribute can be add,update,fix,remove.
<body>
<release version="1.0.0-alpha5" date="YYYY-MM-DD" description="The
1.0.0-alpha5 release requires Java 8.">
<!-- FIX -->
+ <action issue="IMAGING-319" dev="kinow" type="fix" due-to="Stefan
Oltmann, Gary Lucas">
+ Fix EXIF metadata is discarded when updating offsets (wrong
calculation).
+ </action>
<!-- UPDATE -->
<action dev="ggregory" type="update" due-to="Dependabot">Bump
org.apache.commons:commons-parent from 67 to 69 #382.</action>
<action dev="ggregory" type="update" due-to="Dependabot">Bump
commons-io:commons-io from 2.16.0 to 2.16.1 #385.</action>
- <action issue="IMAGING-351" dev="kinow" type="update" due-to="Stefan
Oltmann, Gary Lucas">
+ <action issue="IMAGING-351" dev="kinow" type="update" due-to="Stefan
Oltmann, Gary Lucas, Charles Hope">
Review Comment:
@StefanOltmann didn't have much time to look at history (a bit late, won't
have time tomorrow/next week), so I added [your
suggestion](https://github.com/apache/commons-imaging/pull/366#issuecomment-2053700501)
here :+1:, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
