rproserpio opened a new pull request, #609: URL: https://github.com/apache/commons-io/pull/609
#587 introduces a change in behavior regarding cases where a `ThresholdingOutputStream` is initialized with a negative threshold. Previously, the `thresholdConsumer` would be notified upon the first write, now it is not. The previous behavior was relied upon at least by the `DeferredFileOutputStream` implementation. In this implementation the underlying `currentBuffer` isn't switched from the memory one until the threshold exceeded callback is triggered. If the thresholding output stream has already exceeded the threshold on initialization, the switch never happens. This causes the writes to go to the wrong buffer. I'm not sure what the right approach for a fix would be. On one hand the `isThresholdExceeded` method was incorrect. On the other hand, even if we fix `DeferredFileOutputStream`, other implementations could still rely on the previous behavior. DeferredFileOutputStream is used by commons-fileupload, that is broken when used with commons-io 2.16.0. @elharo @garydgregory, can I ask your opinion on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
