garydgregory commented on PR #609: URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038269279
Hello @rproserpio > I agree. However, this would amount to essentially revert #587 (minus the the tests) and I don't know if that PR was done for some other reasons. Yeah, well, don't get lost in the PR description ;-) I invite you to study the code a bit more and update this PR. You could add comments to the code and test that describe what a negative and zero threshold means or doesn't. It seems you have an app or example in mind and it's always good to have an IRL use case to describe in PR/comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
