aherbert commented on PR #485:
URL:
https://github.com/apache/commons-collections/pull/485#issuecomment-2093082324
I only tested this with:
```
mvn test -Dtest=AbstractLinkedListForJava21Test jacoco:report
```
It seems that if you just run the default `test` phase then the class is not
run (I presume this is due to the name Abstract as a prefix). I renamed to
`DefaultAbstractLinkedListForJava21Test` and then it does run.
We do not hit usage of the sub-list with these tests.
It seems that this functionality was removed in COLLECTIONS-806 when
converting from JUnit4 to JUnit5. Previously `o.a.c.collections4.BulkTest` (the
base for all tests) was used to recursively generate test fixtures via the
custom `makeSuite` method which was called from within a method used by JUnit4
e.g.:
```java
// in CursorableLinkedListTest
public static junit.framework.Test suite() {
return BulkTest.makeSuite(CursorableLinkedListTest.class);
}
```
The javadoc of `BulkTest` refers to this method but commit b860d0c removed
this functionality.
IIUC that commit has removed a large amount of test functionality by
dropping the dynamic generation of tests for sub-collections.
We cannot fix this now. It should be discussed elsewhere (e.g. on the
mailing list). So let's just get this test running and hopefully enough
coverage to pass the thresholds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
