aherbert commented on PR #485:
URL:
https://github.com/apache/commons-collections/pull/485#issuecomment-2095927165
Given that a lot of dynamically generated Junit4 tests were lost in the
conversion to JUnit5, we may have to write some more tests just to get this
into a working build. My initial investigation into fixing the lost tests
discovered only that it is a larger task which is out-of-scope here.
Try pasting this into the current test. These are copied from
`CursorableLinkedListTest`:
```java
@Test
@SuppressWarnings("unchecked")
public void testSubList() {
List<E> list = makeObject();
list.add((E) "A");
list.add((E) "B");
list.add((E) "C");
list.add((E) "D");
list.add((E) "E");
assertEquals("[A, B, C, D, E]", list.toString());
assertEquals("[A, B, C, D, E]", list.subList(0, 5).toString());
assertEquals("[B, C, D, E]", list.subList(1, 5).toString());
assertEquals("[C, D, E]", list.subList(2, 5).toString());
assertEquals("[D, E]", list.subList(3, 5).toString());
assertEquals("[E]", list.subList(4, 5).toString());
assertEquals("[]", list.subList(5, 5).toString());
}
@Test
@SuppressWarnings("unchecked")
public void testSubListAddBegin() {
List<E> list = makeObject();
list.add((E) "A");
list.add((E) "B");
list.add((E) "C");
list.add((E) "D");
list.add((E) "E");
final List<E> sublist = list.subList(0, 0);
sublist.add((E) "a");
assertEquals("[a, A, B, C, D, E]", list.toString());
assertEquals("[a]", sublist.toString());
sublist.add((E) "b");
assertEquals("[a, b, A, B, C, D, E]", list.toString());
assertEquals("[a, b]", sublist.toString());
}
@Test
@SuppressWarnings("unchecked")
public void testSubListAddEnd() {
List<E> list = makeObject();
list.add((E) "A");
list.add((E) "B");
list.add((E) "C");
list.add((E) "D");
list.add((E) "E");
final List<E> sublist = list.subList(5, 5);
sublist.add((E) "F");
assertEquals("[A, B, C, D, E, F]", list.toString());
assertEquals("[F]", sublist.toString());
sublist.add((E) "G");
assertEquals("[A, B, C, D, E, F, G]", list.toString());
assertEquals("[F, G]", sublist.toString());
}
@Test
@SuppressWarnings("unchecked")
public void testSubListAddMiddle() {
List<E> list = makeObject();
list.add((E) "A");
list.add((E) "B");
list.add((E) "C");
list.add((E) "D");
list.add((E) "E");
final List<E> sublist = list.subList(1, 3);
sublist.add((E) "a");
assertEquals("[A, B, C, a, D, E]", list.toString());
assertEquals("[B, C, a]", sublist.toString());
sublist.add((E) "b");
assertEquals("[A, B, C, a, b, D, E]", list.toString());
assertEquals("[B, C, a, b]", sublist.toString());
}
@Test
@SuppressWarnings("unchecked")
public void testSubListRemove() {
List<E> list = makeObject();
list.add((E) "A");
list.add((E) "B");
list.add((E) "C");
list.add((E) "D");
list.add((E) "E");
final List<E> sublist = list.subList(1, 4);
assertEquals("[B, C, D]", sublist.toString());
assertEquals("[A, B, C, D, E]", list.toString());
sublist.remove("C");
assertEquals("[B, D]", sublist.toString());
assertEquals("[A, B, D, E]", list.toString());
sublist.remove(1);
assertEquals("[B]", sublist.toString());
assertEquals("[A, B, E]", list.toString());
sublist.clear();
assertEquals("[]", sublist.toString());
assertEquals("[A, E]", list.toString());
}
```
When I added this locally the coverage is above 85% which may be enough to
get green lights on the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
