garydgregory commented on code in PR #315:
URL:
https://github.com/apache/commons-fileupload/pull/315#discussion_r1607041878
##########
commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/AbstractRequestContext.java:
##########
@@ -20,8 +20,14 @@
import java.util.Objects;
import java.util.function.Function;
import java.util.function.LongSupplier;
+import java.util.regex.Pattern;
public abstract class AbstractRequestContext<T> implements RequestContext {
+ /**
+ * the Content-Type Pattern for multipart/related Requests.
Review Comment:
Sentences start with a capital letter.
##########
commons-fileupload2-jakarta-servlet5/src/main/java/org/apache/commons/fileupload2/jakarta/servlet5/JakartaServletRequestContext.java:
##########
@@ -68,4 +68,13 @@ public InputStream getInputStream() throws IOException {
return getRequest().getInputStream();
}
+ /**
+ * Is the Request of type <code>multipart/related</code>?
+ *
+ * @return the Request is of type <code>multipart/related</code>
+ */
+ @Override
Review Comment:
Add `since` Javadoc tag.
##########
commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java:
##########
@@ -96,6 +95,11 @@ class FileItemInputIteratorImpl implements
FileItemInputIterator {
*/
private boolean eof;
+ /**
+ * is the Request of type <code>multipart/related</code>.
+ */
Review Comment:
Sentences start with a capital letter.
##########
commons-fileupload2-javax/src/main/java/org/apache/commons/fileupload2/javax/JavaxServletRequestContext.java:
##########
@@ -68,4 +68,13 @@ public InputStream getInputStream() throws IOException {
return getRequest().getInputStream();
}
+ /**
+ * Is the Request of type <code>multipart/related</code>?
+ *
+ * @return the Request is of type <code>multipart/related</code>
+ */
+ @Override
Review Comment:
Add `since` Javadoc tag.
##########
commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/AbstractRequestContext.java:
##########
@@ -79,4 +85,7 @@ public String toString() {
return String.format("%s [ContentLength=%s, ContentType=%s]",
getClass().getSimpleName(), getContentLength(), getContentType());
}
+ protected boolean isMultipartRelated(final String contentType) {
Review Comment:
New protected and public items should have a Javadoc and `since` tag.
##########
commons-fileupload2-jakarta-servlet6/src/main/java/org/apache/commons/fileupload2/jakarta/servlet6/JakartaServletRequestContext.java:
##########
@@ -68,4 +68,13 @@ public InputStream getInputStream() throws IOException {
return getRequest().getInputStream();
}
+ /**
+ * Is the Request of type <code>multipart/related</code>?
+ *
+ * @return the Request is of type <code>multipart/related</code>
+ */
Review Comment:
Add `since` Javadoc tag.
##########
commons-fileupload2-portlet/src/main/java/org/apache/commons/fileupload2/portlet/JavaxPortletRequestContext.java:
##########
@@ -68,4 +68,13 @@ public InputStream getInputStream() throws IOException {
return getRequest().getPortletInputStream();
}
+ /**
+ * Is the Request of type <code>multipart/related</code>?
+ *
+ * @return the Request is of type <code>multipart/related</code>
+ */
Review Comment:
Add `since` Javadoc tag.
##########
commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/RequestContext.java:
##########
@@ -70,4 +70,10 @@ default Charset getCharset() throws
UnsupportedCharsetException {
*/
InputStream getInputStream() throws IOException;
+ /**
+ * Is the Request of type <code>multipart/related</code>?
+ *
+ * @return the Request is of type <code>multipart/related</code>
+ */
+ boolean isMultipartRelated();
Review Comment:
Add `since` Javadoc tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
