garydgregory commented on PR #315: URL: https://github.com/apache/commons-fileupload/pull/315#issuecomment-2121069672
Hello @mufasa1976 Note that it's the lines covered ratio that is at issue, not the complexity. You added runtime code like: `org.apache.commons.fileupload2.core.AbstractRequestContext.isMultipartRelated(String)` and its regular expression constant. Since there is no concrete subclass in this module. create a subclass in the tests themselves and make sure the method does the right thing with the regular expression added in the PR. And so on. This should allow the core module to not drop coverage. It should not rely on other modules to test its new code and regular expression anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
