Claudenw commented on code in PR #492:
URL:
https://github.com/apache/commons-collections/pull/492#discussion_r1616130914
##########
src/main/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilter.java:
##########
@@ -172,21 +172,21 @@ default int getMaxInsert(final IndexProducer idxProducer)
{
boolean isValid();
/**
- * Merges the specified BitMap producer into this Bloom filter.
+ * Merges the specified BitMap extractor into this Bloom filter.
*
- * <p>Specifically: all cells for the indexes identified by the {@code
bitMapProducer} will be incremented by 1.</p>
+ * <p>Specifically: all cells for the indexes identified by the {@code
bitMapExtractor} will be incremented by 1.</p>
*
* <p>This method will return {@code true} if the filter is valid after
the operation.</p>
*
- * @param bitMapProducer the BitMapProducer
+ * @param bitMapExtractor the BitMapExtractor
* @return {@code true} if the removal was successful and the state is
valid
* @see #isValid()
- * @see #add(CellProducer)
+ * @see #add(CellExtractor)
*/
@Override
- default boolean merge(final BitMapProducer bitMapProducer) {
- Objects.requireNonNull(bitMapProducer, "bitMapProducer");
- return merge(IndexProducer.fromBitMapProducer(bitMapProducer));
+ default boolean merge(final BitMapExtractor bitMapExtractor) {
+ Objects.requireNonNull(bitMapExtractor, "bitMapExtractor");
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
