Claudenw commented on code in PR #492:
URL:
https://github.com/apache/commons-collections/pull/492#discussion_r1616637306
##########
src/main/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilter.java:
##########
@@ -235,9 +234,12 @@ default boolean merge(final Hasher hasher) {
*
* <p>This method will return {@code true} if the filter is valid after
the operation.</p>
*
- * <p>Note: If indices that are returned multiple times should be
incremented multiple times convert the IndexExtractor
- * to a CellExtractor and add that.</p>
- *
+ * <p>Notes:</p>
+ * <ul>
+ * <li>If indices that are returned multiple times should be incremented
multiple times convert the IndexExtractor
+ * to a CellExtractor and add that.</li>
+ * <li>Implementations should throw {@code IllegalArgumentException} on
and no other exception on bad input.</li>
Review Comment:
good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
