sebbASF commented on PR #1227: URL: https://github.com/apache/commons-lang/pull/1227#issuecomment-2149449334
Yes. This PR does handle that specific syntax, i.e. a pair of single-quotes outside a quoted string. However, SDF also allows such a pair inside a quoted string. For example "'Joan''s birthday is 'EEE, MMM d, yy" Currently the embedded pair are treated ending a string and starting a new one. This PR does not change that, i.e. it does not behave like SDF. But it does allow one to use the format: "'Joan''''s birthday is 'EEE, MMM d, yy" Currently, that is treated 3 separate constant strings (plus date format) This PR treats the 2nd empty constant string as meaning a lone single quote. Whilst that allows for a lone quote without breaking existing tests, it does not agree with SDF, which renders the embedded 4 single-quotes as 2 pairs of single-quotes. Existing tests don't include this possibility, but would be broken by the PR. It is also very awkward to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
