elharo commented on code in PR #1227:
URL: https://github.com/apache/commons-lang/pull/1227#discussion_r1716871318
##########
src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java:
##########
@@ -264,7 +264,12 @@ static String format(final Token[] tokens, final long
years, final long months,
}
if (isLiteral) {
if (!inOptional || !lastOutputZero) {
- buffer.append(value.toString());
+ final String val = value.toString();
Review Comment:
On line 249 what's the actual type? Could we just cast that to string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
