sebbASF commented on PR #300: URL: https://github.com/apache/commons-codec/pull/300#issuecomment-2256855542
I agree that the regex looks wrong. As it stands, it will accept any salt that has at least one alphanumeric character after the $[56]$ prefix. However, the Javadoc for Crypt.crypt(String,String) [1] says: " ... It is therefore valid to enter a complete hash value as salt ..." This would not be possible if the regex was changed as per this PR. [1] https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/digest/Crypt.html#crypt(java.lang.String,java.lang.String) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
