kangxy commented on PR #300: URL: https://github.com/apache/commons-codec/pull/300#issuecomment-2259498794
> The proposed RE does not work because it does not allow for truncating the salt after 16 characters, as per the following test failures: > > Sha256CryptTest.testSha256CryptStrings:63 » IllegalArgument Invalid salt value: $5$1234567890123456789 Sha512CryptTest.testSha512CryptStrings:98 » IllegalArgument Invalid salt value: $6$1234567890123456789 > > There needs to be further work before the RE can be made stricter. Both of the above salt values are wrong. We need the salt to be 16 bytes or less -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
