garydgregory commented on code in PR #725:
URL: https://github.com/apache/commons-lang/pull/725#discussion_r1725782498
##########
src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java:
##########
@@ -128,5 +131,13 @@ public void testToZonedDateTime(final String id) {
final ZonedDateTime zdt1 = ZonedDateTime.of(1, 2, 3, 4, 5, 6, 0,
zoneId);
calendar.setTimeInMillis(zdt1.toInstant().toEpochMilli());
assertEquals(ZonedDateTime.ofInstant(zdt1.toInstant(),
calendar.getTimeZone().toZoneId()), new
CalendarUtils(calendar).toZonedDateTime());
+
+ @Test
Review Comment:
Hello @asgh,
Thank you for your reply and update.
I don't think the implementation is correct because it does not take into
account the Calendar's time zone.
You should be able to see this if you test with time zones and adjust the
test as in my example test using:
```java
@ParameterizedTest
@MethodSource(TimeZonesTest.TIME_ZONE_GET_AVAILABLE_IDS)
```
See also the other tests in this class.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
