asgh commented on code in PR #725:
URL: https://github.com/apache/commons-lang/pull/725#discussion_r1725806063
##########
src/test/java/org/apache/commons/lang3/time/CalendarUtilsTest.java:
##########
@@ -128,5 +131,13 @@ public void testToZonedDateTime(final String id) {
final ZonedDateTime zdt1 = ZonedDateTime.of(1, 2, 3, 4, 5, 6, 0,
zoneId);
calendar.setTimeInMillis(zdt1.toInstant().toEpochMilli());
assertEquals(ZonedDateTime.ofInstant(zdt1.toInstant(),
calendar.getTimeZone().toZoneId()), new
CalendarUtils(calendar).toZonedDateTime());
+
+ @Test
Review Comment:
@garydgregory
I'm really not following you. For this to be wrong this.getDayOfMonth()
would have to be wrong. Are you saying that function returns the wrong day of
the month?
And the entire point is that LocalDate doesn't *have* a timezone. I'm only
setting the timezone in the test so that it correctly converts the UnixTime
into a Month and Day (otherwise it could vary +- a day depending on what
timezone you pick).
If you look at the actual function in the code there is no timezone there
are all.
I will run your assert with some sample data to try to explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
