garydgregory commented on code in PR #283: URL: https://github.com/apache/commons-beanutils/pull/283#discussion_r1740204830
########## src/test/java/org/apache/commons/beanutils2/bugs/Jira273TestCase.java: ########## @@ -16,54 +16,48 @@ */ package org.apache.commons.beanutils2.bugs; -import junit.framework.TestCase; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.fail; import org.apache.commons.beanutils2.PropertyUtils; import org.apache.commons.beanutils2.bugs.other.Jira273BeanFactory; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; /** * Public methods overridden in anonymous or private subclasses are not recognized by PropertyUtils - see issue# BEANUTILS-273. * * @see <a href="https://issues.apache.org/jira/browse/BEANUTILS-273";>https://issues.apache.org/jira/browse/BEANUTILS-273</a> */ -public class Jira273TestCase extends TestCase { +public class Jira273TestCase { private static final Log LOG = LogFactory.getLog(Jira273TestCase.class); - /** - * Create a test case with the specified name. - * - * @param name The name of the test - */ - public Jira273TestCase(final String name) { - super(name); - } - /** * Sets up. * * @throws Exception */ - @Override + @BeforeEach protected void setUp() throws Exception { - super.setUp(); Review Comment: Remove method? ########## src/test/java/org/apache/commons/beanutils2/bugs/Jira273TestCase.java: ########## @@ -16,54 +16,48 @@ */ package org.apache.commons.beanutils2.bugs; -import junit.framework.TestCase; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.fail; import org.apache.commons.beanutils2.PropertyUtils; import org.apache.commons.beanutils2.bugs.other.Jira273BeanFactory; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; /** * Public methods overridden in anonymous or private subclasses are not recognized by PropertyUtils - see issue# BEANUTILS-273. * * @see <a href="https://issues.apache.org/jira/browse/BEANUTILS-273";>https://issues.apache.org/jira/browse/BEANUTILS-273</a> */ -public class Jira273TestCase extends TestCase { +public class Jira273TestCase { private static final Log LOG = LogFactory.getLog(Jira273TestCase.class); - /** - * Create a test case with the specified name. - * - * @param name The name of the test - */ - public Jira273TestCase(final String name) { - super(name); - } - /** * Sets up. * * @throws Exception */ - @Override + @BeforeEach protected void setUp() throws Exception { - super.setUp(); } /** * Tear Down. * * @throws Exception */ - @Override + @AfterEach protected void tearDown() throws Exception { - super.tearDown(); Review Comment: Remove method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
