garydgregory commented on code in PR #283: URL: https://github.com/apache/commons-beanutils/pull/283#discussion_r1740204861
########## src/test/java/org/apache/commons/beanutils2/bugs/Jira298TestCase.java: ########## @@ -16,56 +16,50 @@ */ package org.apache.commons.beanutils2.bugs; -import java.lang.reflect.Method; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.fail; -import junit.framework.TestCase; +import java.lang.reflect.Method; import org.apache.commons.beanutils2.MethodUtils; import org.apache.commons.beanutils2.PropertyUtils; import org.apache.commons.beanutils2.bugs.other.Jira298BeanFactory; import org.apache.commons.beanutils2.bugs.other.Jira298BeanFactory.IX; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; /** * @see <a href="https://issues.apache.org/jira/browse/BEANUTILS-298";>https://issues.apache.org/jira/browse/BEANUTILS-298</a> */ -public class Jira298TestCase extends TestCase { +public class Jira298TestCase { private static final Log LOG = LogFactory.getLog(Jira298TestCase.class); - /** - * Create a test case with the specified name. - * - * @param name The name of the test - */ - public Jira298TestCase(final String name) { - super(name); - } - /** * Sets up. * * @throws Exception */ - @Override + @BeforeEach protected void setUp() throws Exception { - super.setUp(); Review Comment: Remove method? ########## src/test/java/org/apache/commons/beanutils2/bugs/Jira298TestCase.java: ########## @@ -16,56 +16,50 @@ */ package org.apache.commons.beanutils2.bugs; -import java.lang.reflect.Method; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.fail; -import junit.framework.TestCase; +import java.lang.reflect.Method; import org.apache.commons.beanutils2.MethodUtils; import org.apache.commons.beanutils2.PropertyUtils; import org.apache.commons.beanutils2.bugs.other.Jira298BeanFactory; import org.apache.commons.beanutils2.bugs.other.Jira298BeanFactory.IX; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; /** * @see <a href="https://issues.apache.org/jira/browse/BEANUTILS-298";>https://issues.apache.org/jira/browse/BEANUTILS-298</a> */ -public class Jira298TestCase extends TestCase { +public class Jira298TestCase { private static final Log LOG = LogFactory.getLog(Jira298TestCase.class); - /** - * Create a test case with the specified name. - * - * @param name The name of the test - */ - public Jira298TestCase(final String name) { - super(name); - } - /** * Sets up. * * @throws Exception */ - @Override + @BeforeEach protected void setUp() throws Exception { - super.setUp(); } /** * Tear Down. * * @throws Exception */ - @Override + @AfterEach protected void tearDown() throws Exception { - super.tearDown(); Review Comment: Remove method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
