garydgregory commented on PR #568: URL: https://github.com/apache/commons-parent/pull/568#issuecomment-2569139046
Note that I had to revert the Dependabot change because GitHub failed running the file. Also keep in mind that not all Commons components are stuck on Java 8 so doing this check would be counterproductive for Commons DbUtils for example. Gary On Thu, Jan 2, 2025, 04:03 Arnout Engelen ***@***.***> wrote: > So we only need to maintain the version to be the latest that supports > Java 8 here. > > See also apache/commons-bcel#400 > <https://github.com/apache/commons-bcel/pull/400> > > Thanks for your contribution to Apache Commons > <https://commons.apache.org/>! Your help is appreciated! > > Before you push a pull request, review this list: > > - Read the contribution guidelines <http://CONTRIBUTING.md> for this > project. > - Run a successful build using the default Maven > <https://maven.apache.org/> goal with mvn; that's mvn on the command > line by itself. > - Write unit tests that match behavioral changes, where the tests fail > if the changes to the runtime are not applied. This may not always be > possible but is a best-practice. > - Write a pull request description that is detailed enough to > understand what the pull request does, how, and why. > - Each commit in the pull request should have a meaningful subject > line and body. Note that commits might be squashed by a maintainer on merge. > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/commons-parent/pull/568 > Commit Summary > > - e45ac4d > <https://github.com/apache/commons-parent/pull/568/commits/e45ac4df7dbd0e3fb5ec0aa61c365fd61a9628c3> > Add mockito to dependencyManagement > > File Changes > > (2 files <https://github.com/apache/commons-parent/pull/568/files>) > > - *M* .github/dependabot.yml > <https://github.com/apache/commons-parent/pull/568/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28> > (4) > - *M* pom.xml > <https://github.com/apache/commons-parent/pull/568/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8> > (7) > > Patch Links: > > - https://github.com/apache/commons-parent/pull/568.patch > - https://github.com/apache/commons-parent/pull/568.diff > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-parent/pull/568>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAJB6N5YQYZA4TITBYMWIN32IT6FDAVCNFSM6AAAAABUPS43JWVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DKNRWGYYTQMA> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
