On Fri, Jan 3, 2025 at 7:55 AM raboof (via GitHub) <[email protected]> wrote:
> > raboof commented on PR #568: > URL: > https://github.com/apache/commons-parent/pull/568#issuecomment-2569180654 > > > Note that I had to revert the Dependabot change because GitHub failed > running the file. > > Thanks! (for reference: 565af2f74c6a2ba6cd6965d221131060da2d794f, in my > defense :smile: the docs were wrong, filed > https://github.com/github/docs/pull/35818) > I've failed a few builds myself with GH changes ;-) > > > Also keep in mind that not all Commons components are stuck on Java 8 > so doing this check would be counterproductive for Commons DbUtils for > example. > > That's a good point. With that in mind, we should probably not have the > mockito version in the parent pom after all, since which version to pick > depends on whether the project still supports Java 8. > I think it's OK to have the version as a baseline since many components use it. We are in a similar situation with other dependencies like Checkstyle. Gary > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: [email protected] > > For queries about this service, please contact Infrastructure at: > [email protected] > >
