[ 
https://issues.apache.org/jira/browse/IO-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916079#action_12916079
 ] 

Joerg Schaible commented on IO-249:
-----------------------------------

Alternatively provide methods:

{noformat}
IOUtils.closeLogged(<T> closeable); // Use internal logger
IOUtils.closeLogged(<T> closeable, Log logger);
{noformat}

We use this utility functions in our company everywhere instead of 
closeQuietly. However, this would add commons-logging as dependency.

Throwing out of closeQuietly will IMHO contradict the original purpose of the 
method.

> Enhance closeQuietly to indicate success
> ----------------------------------------
>
>                 Key: IO-249
>                 URL: https://issues.apache.org/jira/browse/IO-249
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>            Priority: Minor
>
> A convention of some programmers is to emit a log warning when a resource 
> fails to close. Granted, such a condition is an error, but there's no 
> reasonable recourse to the failure. Using IOUtils.closeQuietly() is very 
> useful but all information about the success/failure is hidden. Returning 
> Throwable will give insight into the error for diagnostic purposes. This 
> change will be compatible with today's usage since the method currently 
> returns void.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to