yuanchaodu commented on code in PR #1569:
URL: https://github.com/apache/commons-lang/pull/1569#discussion_r2698719504


##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -108,9 +108,6 @@ private boolean isApplyNonNull(final String s, final 
Function<String, ?> functio
             assertNotNull(function.apply(s));
             return true;
         } catch (final Exception e) {
-            if (!s.matches(".*\\s.*")) {
-                e.printStackTrace();
-            }

Review Comment:
   Printing stack traces in tests is noisy and makes CI output harder to read.
   Test failures should be reported via assertions instead of stderr output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to