rootvector2 opened a new pull request, #507: URL: https://github.com/apache/commons-bcel/pull/507
`NestHost` and `ModuleMainClass` pass `Const.ATTR_NEST_MEMBERS` to the `Attribute` constructor, so a parsed attribute reports the wrong `getTag()`: a `NestHost` reports `ATTR_NEST_MEMBERS` (26) instead of `ATTR_NEST_HOST` (25), and a `ModuleMainClass` reports 26 instead of `ATTR_MODULE_MAIN_CLASS` (24). `Attribute.readAttribute` selects the right class by name, but the object then mislabels itself, so `JavaClass.getAttribute(Const.ATTR_NEST_HOST)` / `getAttribute(Const.ATTR_MODULE_MAIN_CLASS)` return `null` for a class that has those attributes, while `getAttribute(Const.ATTR_NEST_MEMBERS)` hands back a `NestHost`/`ModuleMainClass` that the unchecked cast type-confuses with `NestMembers`; `Const.getAttributeName(getTag())` also prints both as `NestMembers`. found by checking each `Attribute` subclass tag against `Const` — every other subclass passes its own constant. Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
