rootvector2 opened a new pull request, #691: URL: https://github.com/apache/commons-collections/pull/691
found auditing the map package deserialization paths: the `AbstractHashedMap` and `AbstractReferenceMap` constructors reject a `loadFactor` that is non-positive or `NaN`, but their `doReadObject` overrides read it straight from the stream, so a crafted serialized map deserializes with a `loadFactor` no constructor allows and a `threshold` of 0 that makes `checkCapacity` resize the bucket array on every `put` (a 12-entry map grows its backing array from 16 to 65536); this re-applies the check in both methods (`AbstractReferenceMap` does not call `super.doReadObject`) and throws `InvalidObjectException`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
