rootvector2 commented on PR #517: URL: https://github.com/apache/commons-bcel/pull/517#issuecomment-4896875384
I looked at the 27-ea job: the only failure is `ConstantPoolModuleAccessTest.testJREModules` on `java.base`. 27-ea swapped the internal `sun.text.spi.JavaTimeDateTimePatternProvider` for the new `java.time.format.DateTimeFormatterPatternProvider` in the `uses` list, so the hardcoded expectations drifted. bcel parses the v71 `module-info.class` fine, so it's not a format change, and I agree the format itself is unlikely to move before September. the test already handles this kind of drift with `getMajor()` conditionals, so a `> Const.MAJOR_26` branch covering those two entries would green it. thanks for merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
