garydgregory commented on code in PR #775:
URL: https://github.com/apache/commons-compress/pull/775#discussion_r3553315978
##########
src/test/java/org/apache/commons/compress/archivers/tar/TarUtilsTest.java:
##########
@@ -328,6 +338,19 @@ void testParsePAX1XSparseHeaders() throws Exception {
}
}
+ @Test
+ void testParsePAX1XSparseHeadersDoesNotSkipAlignedDataRecord() throws
Exception {
+ final byte[] fileData = new byte[513];
+ Arrays.fill(fileData, 0, 512, (byte) 'A');
Review Comment:
Hello @OldTruckDriver
What are all these magic numbers?
Is 512 supposed to be `TarConstants.DEFAULT_RCDSIZE` or something else?
Are all the 512 values the same as a coincidence?
Is 513 supposed to be `TarConstants.DEFAULT_RCDSIZE + 1`?
You get the idea...
Please use meaningful local variable names or references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
