OldTruckDriver commented on PR #775: URL: https://github.com/apache/commons-compress/pull/775#issuecomment-4946758404
Thanks for the review @garydgregory. You're right, those numbers should be named. To clarify the intent: 1. 512 is TarConstants.DEFAULT_RCDSIZE and 513 is DEFAULT_RCDSIZE + 1 — the extra byte is what exposes the bug: with the old formula, the reader skips a whole extra record and lands on that trailing byte instead of the first data byte. 2. 100 is the sparse entry count, 200 is the resulting number of offset/size lines, and 108 is only there to pad the header to exactly one record so it's already aligned. I'll push a commit replacing these with named constants/comments shortly. Sorry for the late reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
