rootvector2 opened a new pull request, #418: URL: https://github.com/apache/commons-beanutils/pull/418
`WrapDynaClass.createDynaClass` populates its per-classloader cache with `computeIfAbsent`, but the cache is a plain `WeakHashMap`, so threads that share a context classloader race on an unsynchronized map where `computeIfAbsent` is not atomic: concurrent callers can build and return different `WrapDynaClass` instances for one key, and the structural writes can corrupt the map. Switch the cache to `BeanUtils.createCache()`, the weak-keyed `ConcurrentReferenceHashMap` that `MethodUtils`, `ConvertUtilsBean` and `PropertyUtilsBean` already use. Found while auditing the package's `computeIfAbsent` call sites against those thread-safe caches. Like the `MethodUtils` visibility fix this race has no deterministic unit test so none is added, though a stress loop over concurrent `createDynaClass` calls does surface the duplicate instances. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
