sahvx655-wq commented on PR #430: URL: https://github.com/apache/commons-validator/pull/430#issuecomment-5116919669
Pushed the review changes. The copilot points are folded in as well: the two private isNextToSymbol copies are gone, both validators now share a single package-private BigDecimalValidator.removeSymbol(pattern, symbol) with the adjacency checks explicitly parenthesised, and the test locals that shadowed the fixture field are renamed to instance. That also removes the pre-existing duplication of the strip loop itself, so the currency and percent paths can no longer drift apart. Full default-goal build with -Ddoclint=all is green: 1154 tests, 0 failures, checkstyle, pmd, spotbugs and javadoc all clean. I also re-ran the new tests against master's validators to confirm every parameterised locale case fails without the fix before it passes with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
