sahvx655-wq commented on PR #430: URL: https://github.com/apache/commons-validator/pull/430#issuecomment-5117638567
Extended this per the 'better yet, for all known currency symbols' remark: the explicit-pattern tests are no longer pinned to en-US, they're parameterised over Locale.getAvailableLocales() with the inputs formatted through each locale's own DecimalFormatSymbols. That exercises the strip for every currency and percent symbol the JVM ships, including the multi-character symbols and the locales with non-Latin digits, without the expectations depending on any one locale's data. Ran the sweep against master's validators first to make sure it still bites: all 2138 locale cases fail there with 'no symbol ==> expected: <1234.56> but was: <null>' and pass with the fix. Full default-goal build with -Ddoclint=all is green afterwards: 3290 tests, checkstyle, pmd and spotbugs all clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
