rootvector2 opened a new pull request, #719: URL: https://github.com/apache/commons-collections/pull/719
`OrderedProperties.keySet()` hands out `orderedKeys` itself, the private `LinkedHashSet` that tracks insertion order, so mutations through the returned set never reach the backing `Hashtable`. `keySet().remove(k)` reports success and drops the key from `keys()`, `entrySet()` and `store()` while `getProperty(k)` still returns the value, and `keySet().add(k)` succeeds where a key set view has to reject it. `values()` has the mirror problem: it is not overridden, so the inherited view deletes the mapping and leaves a stale key behind, which makes `toString()` throw. Both now return small views whose removals route through the map, so the order tracker and the store move together. Keeping it in the views is what makes the plain `Properties` idioms work here, rather than callers having to know that `remove(k)` is the only safe way to delete a key. Found by running SpotBugs over the module, which flags the `keySet()` return as exposed internal state. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
