fkjellberg opened a new pull request, #804: URL: https://github.com/apache/commons-compress/pull/804
Generated-by: Claude Opus 5 <[email protected]> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [X] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [X] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [X] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [X] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [X] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. The documentation for `HuffmanDecoder` states that the code lengths must not violate Kraft's inequality but this is never checked. It turns out that some of the existing test cases violate this prerequisite. `HuffmanDecoder` will now throw `CompressorException` if the code lengths violate Kraft's inequality. Without this early check before actually start decoding, the decoder may output corrupt data that hopefully will be detected by the CRC checksum or it may throw other unexpected exceptions while decoding the input stream. I used Claude Opus 5 to generate some of the code and to help investigate and fix the failing test cases. Generated-by: Claude Opus 5 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
