alhudz opened a new pull request, #1775:
URL: https://github.com/apache/commons-lang/pull/1775
Repro: `CharRange.isIn('a',
Character.MAX_VALUE).contains(CharRange.isNotIn((char) 0, (char) ('a' - 1)))`
returns `false`, but the argument denotes `['a', MAX_VALUE]`, the same set as
the receiver, so it should be `true`.
`CharRange.is('x').contains(CharRange.isNotIn((char) 0, Character.MAX_VALUE))`
also returns `false` although the argument is the empty set.
Cause: in the non-negated-receiver / negated-argument branch,
`contains(CharRange)` only accepts a negated argument when the receiver is the
full `[0, MAX_VALUE]` range. A negated range denotes `[0, start - 1]` union
`[end + 1, MAX_VALUE]`, which is empty when it spans the whole domain and a
single contiguous interval when its excluded range touches `0` or `MAX_VALUE`;
a smaller receiver can hold those.
Fix: handle the empty-set and single-interval cases in that branch, keeping
the full-range requirement only when the excluded range is strictly interior.
The other three negation combinations are left as they were.
Checked against the per-character oracle `contains(char)` over a boundary
sweep: 422 mismatches before, 0 after. Regression assertions added in
`CharRangeTest`.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
