rmuir commented on code in PR #811:
URL: https://github.com/apache/commons-compress/pull/811#discussion_r3882633907
##########
src/main/java/org/apache/commons/compress/compressors/bzip2/CRC.java:
##########
@@ -50,6 +50,25 @@ final class CRC {
0xf464a0aa, 0xf9278673, 0xfde69bc4, 0x89b8fd09, 0x8d79e0be,
0x803ac667, 0x84fbdbd0, 0x9abc8bd5, 0x9e7d9662, 0x933eb0bb, 0x97ffad0c,
0xafb010b1,
0xab710d06, 0xa6322bdf, 0xa2f33668, 0xbcb4666d, 0xb8757bda,
0xb5365d03, 0xb1f740b4 };
+ /**
+ * Slicing-by-8 tables: {@code SLICE[k][i]} is the CRC contribution of
byte {@code i} followed by {@code k} zero bytes; {@code SLICE[0]} is
+ * {@link #CRC32_TABLE}.
Review Comment:
java.util.zip.CRC32 is the one i mean indeed. It is in java 8. This is the
one lucene uses. I spent a ton of time benchmarking those parts. It is insanely
fast, just give it enough buffer so that the vectorization can happen (don't
give it like just a few bytes at a time). I think 1K or so is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
