sharanggupta commented on PR #1812:
URL: https://github.com/apache/commons-lang/pull/1812#issuecomment-6041344489
Hi @garydgregory,
Thanks for catching those issues! I've pushed a follow-up commit that
addresses both Copilot findings:
Guard cyclic owner traversal — Added cycle tracking via a visited set in
containsTypeVariables() to prevent StackOverflowError when a ParameterizedType
has self-referential or mutually cyclic owners.
Prevent wildcard owner unrolling from losing cycle state — Created an
overload of unrollBounds() that accepts and preserves the visited set
throughout wildcard bound processing, maintaining cycle detection state.
All 435 TypeUtilsTest tests pass with no regressions. The full suite also
completed successfully (exit code 0).
The fixes allow:
Outer<T>.Inner<T> owner traversal without stack overflow
Wildcard cyclic assignments like {T -> Outer<? extends T>.Inner} to unroll
safely
Ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
