alhudz opened a new pull request, #1817: URL: https://github.com/apache/commons-lang/pull/1817
Repro: `RandomUtils.nextDouble(10, Math.nextUp(10))`; expected a value strictly below `endExclusive`, actual `10.000000000000002` (the exclusive bound) on 4953 of 10000 calls. `nextFloat` and the instance `randomDouble`/`randomFloat` behave the same. Cause: `randomDouble`/`randomFloat` scale with `startInclusive + (endExclusive - startInclusive) * nextDouble()`, and rounding in the multiply and add can land exactly on `endExclusive`, which the Javadoc documents as not included. Same mechanism as LANG-1592, which fixed `nextLong(long, long)`; the double and float paths kept the unclamped scaling. Fix: clamp an out-of-range result to `Math.nextDown(endExclusive)`, the correction `java.util.Random#nextDouble(double, double)` applies. The regression tests use a range one ULP wide, where the unpatched code returns the bound about half of the time; they fail before the change and pass after, and the default `mvn` goal is green. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code was used to find the defect and draft the fix and tests; the change was reviewed and the build and tests were run locally before submitting. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
