tarunkishore2303 commented on code in PR #1816:
URL: https://github.com/apache/commons-lang/pull/1816#discussion_r4262572564
##########
src/main/java/org/apache/commons/lang3/CharUtils.java:
##########
@@ -460,8 +460,8 @@ public static int toIntValue(final char ch) {
}
/**
- * Converts the character to the Integer it represents, throwing an
- * exception if the character is not numeric.
+ * Converts the character to the Integer it represents, returning the
+ * default value if the character is not ASCII numeric.
Review Comment:
Updated in 0600512: the Javadoc now says "not an ASCII digit ('0' to '9')",
with the character literals formatted using {@code}. This makes the accepted
range explicit. All 27 CharUtils tests, Checkstyle, and Javadoc generation
passed.
##########
src/main/java/org/apache/commons/lang3/CharUtils.java:
##########
@@ -504,8 +504,8 @@ public static int toIntValue(final Character ch) {
}
/**
- * Converts the character to the Integer it represents, throwing an
- * exception if the character is not numeric.
+ * Converts the character to the Integer it represents, returning the
+ * default value if the character is not ASCII numeric.
Review Comment:
Updated this overload in 0600512 as well, using the same explicit "ASCII
digit ('0' to '9')" wording as the char overload. All 27 CharUtils tests,
Checkstyle, and Javadoc generation passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
