alhudz opened a new pull request, #1818:
URL: https://github.com/apache/commons-lang/pull/1818
`ClassUtils.getShortClassName(Class)` builds the short name by walking
`getDeclaringClass()` and joining `getSimpleName()` parts, with a name-based
fallback only when the leaf class itself is anonymous or local. The declaring
chain of a member class nested in an anonymous or local class ends at that
enclosing class (an anonymous class has an empty simple name and no declaring
class; a local class has no declaring class), so the enclosing context is
silently dropped.
Repro, inside a top-level class `Example`:
```java
Class<?> memberOfAnonymous = new Object() { class Inner {}
}.getClass().getDeclaredClasses()[0];
class Local { class Inner {} }
ClassUtils.getShortClassName(memberOfAnonymous); // ".Inner" where
getShortClassName(getName()) gives "Example.1.Inner"
ClassUtils.getShortClassName(Local.Inner.class); // "Local.Inner" where
getShortClassName(getName()) gives "Example.1Local.Inner"
```
Cause: the anonymous/local fallback added with the #1591/#1665 rewrite
checks only the leaf class, not the enclosing chain.
Fix: stop the declaring-chain walk at the first anonymous or local class in
the chain and take the name-based form for the whole chain, which keeps the
outer classes the Javadoc promises and the compiler ordinals. Leaf
anonymous/local classes and the LANG-1818 handling of `$` in simple names
behave as before. The regression shipped in 3.21.0 and is visible through
`ToStringStyle` and `ExceptionUtils`, which render class names with this method.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Claude
Code found the bug and prepared the fix and the test; I reviewed the change
before submitting.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
