alhudz commented on PR #1818: URL: https://github.com/apache/commons-lang/pull/1818#issuecomment-6186842169
@garydgregory Rebased on master. You were right: the whole-name fallback turned `Local.Inner$Name` into `...1Local.Inner.Name` and failed `testDollarSignWithinMemberOfLocalClass`. Fix: only the anonymous/local enclosure now goes through the name-based form, and the simple names of the member classes below it are appended as before. So the outer class and ordinal are kept and `$` in member names is kept too: - `Local.Inner` -> `ClassUtilsShortClassNameTest.2Local.Inner` (master gives `Local.Inner`) - anonymous `Inner` -> `ClassUtilsShortClassNameTest.2.Inner` (master gives `.Inner`) - anonymous `Inner$Name` -> `ClassUtilsShortClassNameTest.1.Inner$Name` (master gives `.Inner$Name`) Tests moved to `ClassUtilsShortClassNameTest`, and the three new ones fail on master. `mvn` default goal is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
