SABITHSAHEB opened a new pull request, #295: URL: https://github.com/apache/commons-jxpath/pull/295
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code found the defect and wrote the fix and the test updates; I reviewed the change before submitting. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. `CoreOperationCompare.equal`, the shared evaluator for `=` and `!=`, returns false early when either operand converts to NaN, which bypasses the `result ^ invert` step that turns the equality result into `!=`. XPath 1.0 section 3.4 compares numbers per IEEE 754, where NaN is not equal to anything, including itself, so `$nan = $nan` is false but `$nan != $nan`, `$nan != 0` and `number('foo') != 1` must all be true; Xalan and libxml2 both answer true. JXPath answers false for both operators, so a predicate like `txns[amount != 0]` silently drops a node whose caller-supplied `amount` is a non-numeric string (its number value is NaN) instead of selecting it, and a filter written to catch every value different from the expected one is bypassed by a value that does not parse as a number. This completes [JXPATH-95](https://issues.apache.org/jira/browse/JXPATH-95): the reporter pointed out there that `$nan != 1` must be true, but the follow-up commit 40689aa2 made every NaN comparison return false and encoded that in `testNan`. Java's `==` on doubles already follows IEEE 754, so the fix deletes the early returns and lets the comparison flow through the inversion. `=`, `<`, `>`, `<=`, `>=` with NaN all stay false, and empty node-set comparisons are unaffected (`testEmptyNodeSetOperations` still passes). The updated `testNan` expectations and the new string-coercion assertions fail on the current code and pass with the fix; the default `mvn` goal passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
