sofialuiza15 opened a new pull request, #921: URL: https://github.com/apache/commons-io/pull/921
The private inner class `FileCleaningTracker.Reaper` extended `Thread` but only used `run()`. It inherited the whole `Thread` API without needing it (Refused Bequest), and mixed the cleaning logic with the thread configuration. - `Reaper` now implements `Runnable`; its constructor is removed. - Thread name, priority and daemon flag are set where the thread is created, in `addTracker`. Behavior is unchanged: same thread name (`commons-io-FileCleaningTracker-Reaper`), same `MAX_PRIORITY`, still a daemon thread. The package-private `reaper` field is still a `Thread`, so existing tests that use `join()`/`isAlive()` work as before. Refactoring: Replace Inheritance with Delegation (composition over inheritance). `Reaper` is private, so there is no public API or binary compatibility impact. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Sonnet 5.5) made the code change; I reviewed it and ran the related tests. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. Validated with mvn -B -ntp (Maven 3.10.0): BUILD SUCCESS. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. Not applicable: pure refactoring with no behavioral change. Existing tests cover it and were not modified. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
