oscerd opened a new pull request, #450:
URL: https://github.com/apache/commons-cli/pull/450
If you reuse an `Options` instance and pass `Properties` to
`DefaultParser.parse()`, the first parse leaves the property value behind in
the `Option` registered in `Options`: `handleProperties()` called
`processValue()` on that registered option rather than on the copy that goes
into the `CommandLine`, and nothing ever clears it. From then on the same
`Options` gives wrong answers:
- a later parse with a different property value still returns the first one;
- `-o value` on the command line returns the old property value, and `value`
ends up in the argument list;
- with a `-D` style option (`hasArgs().valueSeparator('=')`), pairs from the
earlier properties show up in the next parse's `getOptionProperties()`.
The fix adds the value to the copy instead, the same way values from the
command line are handled, so parsing no longer changes `Options`. The three new
tests in `DefaultParserTest` fail on master and pass with the change.
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code (Claude Opus 5.5) was used to analyze the issue and to
prepare the change, its tests and this description.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
