sofialuiza15 opened a new pull request, #920: URL: https://github.com/apache/commons-io/pull/920
Improves naming in `HexDump.dump(byte[], long, Appendable, int, int)` and its private helpers. No behavior or public API change. - `chars_read` -> `bytesInLine` (it counts bytes, nothing is "read" there) - `display_offset` -> `displayOffset` (snake_case -> camelCase, as in the rest of the project) - `j` -> `lineStart`, `k` -> `column` - private `dump(StringBuilder, byte)` / `dump(StringBuilder, long)` -> `appendHex(...)`, since they only append hex digits and shared a name with the public `dump` methods - `j` -> `digit` in the helpers - Javadoc of the helpers updated: `appendHex(StringBuilder, long)` now says it writes only the 32 least significant bits, which is what the code does. Refactoring: Rename Variable / Rename Method. Only private members and local variables are touched, so binary compatibility is unaffected. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Sonnet 5.5) made the code change and drafted this description; I reviewed it and ran the related tests. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. Validated with mvn -B -ntp (Maven 3.10.0): BUILD SUCCESS. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. Not applicable: pure refactoring with no behavioral change. Existing tests cover it and were not modified. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
