oscerd opened a new pull request, #448: URL: https://github.com/apache/commons-cli/pull/448
Options of type `FileInputStream` (the `<` code in `PatternOptionBuilder`, or `TypeHandler.openFile()`) open the file as soon as the value is converted and hand back an open stream. The Javadoc didn't say that the caller is responsible for closing it, or that opening a special file such as a named pipe blocks, exactly like `new FileInputStream(String)` does. This documents both in `TypeHandler` and `openFile()`, and adds the missing `<` row to the `PatternOptionBuilder` table. Javadoc only, no behavior change. - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Opus 5.5) was used to analyze the issue and to prepare the change and this description. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. Not applicable: Javadoc only. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
