AmarGhugare opened a new pull request, #1890:
URL: https://github.com/apache/commons-lang/pull/1890
Two Javadoc example blocks show calls that do not compile or do not give the
documented result.
`ObjectUtils.getFirstNonNull(Supplier...)`:
- All five examples call `ObjectUtils.firstNonNullLazy(...)`, but
ObjectUtils has no method with that name. The examples now call
`getFirstNonNull`.
- `() -> throw new IllegalStateException()` is not a valid lambda. It is now
`() -> { throw new IllegalStateException(); }`.
- `() -> "zz)` is missing its closing quote.
`BooleanUtils.toBooleanObject(Integer)`:
- `toBooleanObject(Integer.valueOf(null))` resolves to
`Integer.valueOf(String)` and throws `NumberFormatException` before
`toBooleanObject` runs. The example now uses `(Integer) null`, which returns
`null` as documented (already covered by `BooleanUtilsTest`).
I ran each corrected example against the current master classes and they
return the documented values. This is a Javadoc-only change with no runtime
change, so there are no new tests.
No JIRA ticket exists for this. I don't have an ASF JIRA account, and the
change is limited to Javadoc examples.
Before you push a pull request, review this list:
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code (Anthropic) found the wrong examples by evaluating
Javadoc examples against the compiled classes and drafted the corrections. I
reviewed the change and ran the build.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]