[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080586#comment-13080586
]
Tamas Kende commented on CODEC-125:
-----------------------------------
Matthew:
I have some questions/observations about the tests.
In the LanguageGuessingTest we never use the exactness parameter.
Would not it make sense to add surnames with accented chars to the
PhoneticEngineTest class? like: Schäffer (German), Győrössy (Hungarian),
Mészáros (Hungarian). I cannot provide you examples from the php version,
because it was broken to me and skipped the accented chars. I know it won't
increase the code coverage, but probably increase the "resource coverage" if
you know what I mean.
Something is still wrong with the performance. I've ran the speedCheck for a
few times, and I received the infinitive loop once or twice. My PC is not the
greatest and latest, but it has an Intel Core2Duo 3Ghz with 6 Gb RAM and Win7,
but it took 2-14 sec to run this method, it means there is still something in
the background. Can someone run this method 20 or more times to see what
happens? So we should put back the commented time limitation.
> Implement a Beider-Morse phonetic matching codec
> ------------------------------------------------
>
> Key: CODEC-125
> URL: https://issues.apache.org/jira/browse/CODEC-125
> Project: Commons Codec
> Issue Type: New Feature
> Reporter: Matthew Pocock
> Priority: Minor
> Attachments: acz.patch, bm-gg.diff, bmpm.patch, bmpm.patch,
> bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch,
> fixmeInvariant.patch, handleH.patch, majorFix.patch,
> performanceAndBugs.patch, testEncodeGna.patch
>
>
> I have implemented Beider Morse Phonetic Matching as a codec against the
> commons-codec svn trunk. I would like to contribute this to commons-codec.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
