[ 
https://issues.apache.org/jira/browse/MATH-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182400#comment-13182400
 ] 

Dennis Hendriks commented on MATH-730:
--------------------------------------

bq. Thanks Dennis for this contribution!

Thank you for committing it.

bq. Are you OK if I resolve this issue?

One small issue: RandomDataImpl.nextUniform(double, double) has different 
@throws (exception class and message) than nextUniform(double, double, 
boolean). They should probably be identical, as one calls the other.

And one question: What is the reason for not including the @throws for the 2 
methods in the interface as well? Don't we expect all implementations to 
conform to that exception in that exact case? That would allow users to catch 
it, regardless of the actual implementation class.
                
> Add uniform distributions (integer and real)
> --------------------------------------------
>
>                 Key: MATH-730
>                 URL: https://issues.apache.org/jira/browse/MATH-730
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Dennis Hendriks
>              Labels: distribution
>             Fix For: 3.0
>
>         Attachments: uniform-distributions.patch
>
>
> Add UniformIntegerDistribution and UniformRealDistribution classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to