[
https://issues.apache.org/jira/browse/MATH-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186732#comment-13186732
]
Sébastien Brisard commented on MATH-733:
----------------------------------------
Hi Dennis,
thanks for this contribution. I've looked into it, and am uncomfortable with
the naming conventions {{mean}} and {{standardDeviation}} which are *not* the
mean and sd of the log-normal distribution, but rather the underlying normal
distribution.
Would you object to my renaming all these parameters and class variables to
{{scale}} and {{shape}}, as you yourself mention these naming conventions in
the javadoc? I would then move your explanation of the definition of these
parameters to the class's documentation comment.
>From the user's perspective (heavily relying on automatic completion) I think
>it is dangerous that {{getMean()}} should *not* return the mean value of the
>current distribution. Of course, your javadoc comments are very clear, but...
>Also, my experience in materials science is that people are always a bit
>"fuzzy" about log-normal distributions. What they call "sigma" is never very
>clear...
Please let me know what you think.
> Add LogNormal distribution
> --------------------------
>
> Key: MATH-733
> URL: https://issues.apache.org/jira/browse/MATH-733
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Dennis Hendriks
> Labels: distribution
> Fix For: 3.0
>
> Attachments: lognormal_distribution.patch
>
>
> It would be nice to have a log-normal distribution.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
