[ 
https://issues.apache.org/jira/browse/MATH-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187556#comment-13187556
 ] 

Dennis Hendriks commented on MATH-733:
--------------------------------------

bq. please have a look to r1232324 [...]

Some comments:
 - LogNormalDistribution constructor: LocalizedFormats.STANDARD_DEVIATION -> 
change to LocalizedFormats.NOT_POSITIVE_SHAPE
 - LogNormalDistributionTest: testGetMean -> testGetScale, 
testGetStandardDeviation -> testGetShape
 - LogNormalDistributionTest: checkDensity function: rename 'mean' and 'sd' 
parameters

Also, the <a id="parameters">...</a> and <a href="#parameters">scale</a> stuff 
is not Eclipse Java text editor compatible. It probably works just fine in the 
html pages generated from the Javadoc. However, I would prefer to stick with 
{@link ...}, if possible.
                
> Add LogNormal distribution
> --------------------------
>
>                 Key: MATH-733
>                 URL: https://issues.apache.org/jira/browse/MATH-733
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Dennis Hendriks
>            Assignee: Sébastien Brisard
>              Labels: distribution
>             Fix For: 3.0
>
>         Attachments: lognormal_distribution.patch
>
>
> It would be nice to have a log-normal distribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to