[
https://issues.apache.org/jira/browse/SANSELAN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200799#comment-13200799
]
Damjan Jovanovic commented on SANSELAN-42:
------------------------------------------
In recent commits:
IPTC_PREFIX - deleted, it's obsoleted by 2 other fields
IPTC_TYPES - converted to enum
In commit 1240761:
formats.jpeg.JpegImageParser.AcceptedExtensions - made private, but still leaks
out via getter: this is a global problem
icc.IccConstants.IccTagDataTypes - converted to enum
icc.IccConstants.IccTagTypes - converted to enum
TODO:
formats.jpeg.JpegConstants.EOI, SOI, MARKERS etc (many in that class)
formats.png.PngConstants.PNG_Signature
formats.png.ScanExpediterInterlaced.Starting_Row etc.
formats.tiff.constants.AllTagConstants.ALL_TAGS
formats.tiff.constants.TiffFieldTypeConstants.FIELD_TYPES
formats.tiff.constants.TiffFieldTypeConstants.FIELD_TYPE_ANY et.c
formats.tiff.constants.TiffTagConstants.ALL_TIFF_TAGS
> IPTCConstants: final arrays are not immutable
> ---------------------------------------------
>
> Key: SANSELAN-42
> URL: https://issues.apache.org/jira/browse/SANSELAN-42
> Project: Commons Sanselan
> Issue Type: Bug
> Reporter: Sebb
>
> formats.jpeg.iptc.IPTCConstants contains the following public static final
> arrays:
> IPTC_PREFIX
> IPTC_TYPES
> Array element are not immutable, even if the array itself is, so the entries
> could potentially be corrupted accidentally or deliberately.
> IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not,
> it could be made private and a getter added.
> IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be
> moved there and made private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
