[ 
https://issues.apache.org/jira/browse/SANSELAN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202514#comment-13202514
 ] 

Damjan Jovanovic commented on SANSELAN-42:
------------------------------------------

TiffTagConstants -> enum + unmodifiableList
GpsTagConstants -> enum + unmodifiableList
ExifTagConstants -> enum + unmodifiableList
AllTagConstants -> unmodifiableList

TODO:
formats.jpeg.JpegConstants.EOI, SOI, MARKERS etc (many in that class)
formats.png.PngConstants.PNG_Signature
formats.tiff.constants.TiffFieldTypeConstants.*
formats.tiff.constants.TiffDirectoryConstants.*

                
> IPTCConstants: final arrays are not immutable
> ---------------------------------------------
>
>                 Key: SANSELAN-42
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-42
>             Project: Commons Sanselan
>          Issue Type: Bug
>            Reporter: Sebb
>
> formats.jpeg.iptc.IPTCConstants contains the following public static final 
> arrays:
> IPTC_PREFIX
> IPTC_TYPES
> Array element are not immutable, even if the array itself is, so the entries 
> could potentially be corrupted accidentally or deliberately.
> IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not, 
> it could be made private and a getter added.
> IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be 
> moved there and made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to